Cleanups for fully typed build_target arguments #15406
Open
+69
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…targets include_directories, dependencies, and link_with are all valid for jar targets as well as compiled targets.
We know all of the keyword arguments now! This also allows them to be removed from wrappers
41 tasks
These were hidden by the `if 'sources' in kwargs` check, which mypy thought would always be true, and thus it just ignored everything else. Of course, these issues are just the static type checking not understanding...
This fixes the SharedLibrary preventing the SharedModule from being used.
This cleans up the typing by creating a new dictionary instead of mutating the one passed in. This gives better typing controls. I've also adding some missing keyword argument annotations, and done some casting because lists are invariant.
dcbaker
force-pushed
the
submit/fully-typed-build-arguments-cleanups
branch
from
bccbaf9 to
cfd350e
Compare
Member
Author
|
Sigh, none of the mypy issues can be demonstrated on my machine. This must be a mypy 1.8 issue. Maybe after the new years. |
Member
Author
|
Cannot be merged until mypy is unpinned, so it will have to wait to 1.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cleanups made possible by the fully typed build_target arguments.
The first patch moves some things that apply to jar into the shared-with-jar state. This was hidden by the
allow_unknown=True.Then there's some cleanups for the simd module since we can now be sure that no extra keyword arguments are passed
Finally, we can clean up the python module and get the fully type safe.