Skip to content

Conversation

@pobrn
Copy link
Contributor

@pobrn pobrn commented Dec 23, 2025

Please see the individual commit messages for more detail.

@neheb
Copy link
Collaborator

neheb commented Dec 23, 2025

0.63.0: c_std in subproject default_options

@pobrn
Copy link
Contributor Author

pobrn commented Dec 23, 2025

0.63.0: c_std in subproject default_options

Should I have seen this warning locally?

@pobrn pobrn force-pushed the update_lua_5.5.0 branch 2 times, most recently from d54136a to 47d5d10 Compare December 24, 2025 19:45
@neheb
Copy link
Collaborator

neheb commented Dec 27, 2025

It's implemented in Actions.

@pobrn
Copy link
Contributor Author

pobrn commented Jan 7, 2026

It's implemented in Actions.

Ahh, I see. It should be fixed now, hopefully.

@neheb
Copy link
Collaborator

neheb commented Jan 26, 2026

Nothing has been fixed.

The project name is an arbitrary string, since it has no effect on
functionality, remove the version number so that fewer places need
to be changed when updating.
@pobrn pobrn force-pushed the update_lua_5.5.0 branch 3 times, most recently from a71b579 to 29372bc Compare January 26, 2026 17:28
@pobrn
Copy link
Contributor Author

pobrn commented Jan 26, 2026

Nothing has been fixed.

I'm sorry, but you'll have to help me out here. The wrap file has

  meson_version: '>=0.63.0',

but https://github.com/mesonbuild/wrapdb/actions/runs/21367306662/job/61502520768?pr=2573#step:7:34 says the targeted minimum version is 0.56.0? What am I missing?

@neheb
Copy link
Collaborator

neheb commented Jan 26, 2026

something like this:

--- a/subprojects/packagefiles/lua/meson.build
+++ b/subprojects/packagefiles/lua/meson.build
@@ -4,7 +4,6 @@ project(
   license: 'MIT',
   meson_version: '>=0.49.2',
   version: '5.4.8',
-  default_options: ['c_std=c99', 'warning_level=2'],
 )

 lua_versions = meson.project_version().split('.')
@@ -41,6 +40,8 @@ elif get_option('default_library') != 'static' and host_machine.system() == 'win
   )
 endif

+lua_lib_args = ['c_std=c99', 'warning_level=2'],
+
 # Library dependencies.
 lua_lib_deps = [
   cc.find_library(
@@ -71,7 +72,7 @@ endif

 # Interpreter dependencies.
 lua_exe_deps = []
-lua_exe_args = []
+lua_exe_args = ['c_std=c99', 'warning_level=2'],

 readline_dep = dependency(
   'readline',
@@ -122,6 +123,7 @@ lua_lib = library(
   'src/lutf8lib.c',
   'src/lvm.c',
   'src/lzio.c',
+  c_args: lua_lib_args,
   dependencies: lua_lib_deps,
   version: meson.project_version(),
   soversion: lua_versions[0] + '.' + lua_versions[1],

pobrn added 2 commits January 26, 2026 23:51
Among others:

  * 0.56.0: oldest version supported by WrapDB
  * 0.63.0: c_std in subproject default_options
  * using `dependency_names` in wrap file and overriding dependencies
Lua 5.5.0 was released on 2025-12-22[0]; update the wrap to use that version,
no major changes are needed.

[0]: https://lua.org/versions.html#5.5
@pobrn pobrn force-pushed the update_lua_5.5.0 branch 2 times, most recently from 91881b9 to 4b4fa85 Compare January 26, 2026 22:59
@neheb neheb merged commit 91f52e6 into mesonbuild:master Jan 26, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants