bshoshany-thread-pool: update to v5.1.0 #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
Jan 4, 2026
| endif | ||
|
|
||
| if meson.version().version_compare('>=0.54.0') | ||
| if meson.version().version_compare('>=0.56.0') |
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment, @neheb! To be honest, I don't actually use meson myself - someone else wrote this and I just bump the project version whenever I update my package. I changed the required meson version because the checks fail otherwise, but I'm not sure what that if statement does in the first place, so I didn't remove it. It seems like it overrides a dependency; can the dependency just be defined correctly in the first place, so both the if and the override can be removed?
Collaborator
There was a problem hiding this comment.
The if statement is there for compatibility with older meson versions. Except older meson versions are no longer supported. Just get rid of the if statement and leave the override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just released v5.1.0.