Add integration tests for Calls, CallFlows and Webhooks

Author: polyfloyd

voice/call.go

@@ -107,9 +107,13 @@ func (call *Call) UnmarshalJSON(data []byte) error {
 //
 // An error is returned if no such call flow exists or is accessible.
 func CallByID(client *messagebird.Client, id string) (*Call, error) {
-	call := &Call{}
-	err := client.Request(call, http.MethodGet, apiRoot+"/calls/"+id, nil)
-	return call, err
+	var resp struct {
+		Data []Call `json:"data"`
+	}
+	if err := client.Request(&resp, http.MethodGet, apiRoot+"/calls/"+id, nil); err != nil {
+		return nil, err
+	}
+	return &resp.Data[0], nil
 }
 
 // Calls returns a Paginator which iterates over all Calls.

voice/call_test.go

@@ -31,3 +31,39 @@ func TestInitiateCall(t *testing.T) {
 		t.Fatal(err)
 	}
 }
+
+func TestCallByID(t *testing.T) {
+	client, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	source, destination := "31000000000", "31000000000"
+	callflow := CallFlow{
+		Title: "Say test",
+		Steps: []CallFlowStep{
+			&CallFlowSayStep{
+				Voice:    "male",
+				Payload:  "You are about to experience a great adventure which reaches from the inner mind to the outer limits",
+				Language: "en-US",
+			},
+			&CallFlowPauseStep{
+				Length: time.Second,
+			},
+			&CallFlowHangupStep{},
+		},
+	}
+	call, err := InitiateCall(client, source, destination, callflow, nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	time.Sleep(time.Second)
+	fetchedCall, err := CallByID(client, call.ID)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if fetchedCall.Source != call.Source {
+		t.Fatalf("mismatched source: exp %q, got %q", call.Source, fetchedCall.Source)
+	}
+}

voice/callflow.go

@@ -105,9 +105,13 @@ func (callflow *CallFlow) UnmarshalJSON(data []byte) error {
 //
 // An error is returned if no such call flow exists or is accessible.
 func CallFlowByID(client *messagebird.Client, id string) (*CallFlow, error) {
-	callflow := &CallFlow{}
-	err := client.Request(callflow, http.MethodGet, apiRoot+"/call-flows/"+id, nil)
-	return callflow, err
+	var data struct {
+		Data []CallFlow `json:"data"`
+	}
+	if err := client.Request(&data, http.MethodGet, apiRoot+"/call-flows/"+id, nil); err != nil {
+		return nil, err
+	}
+	return &data.Data[0], nil
 }
 
 // CallFlows returns a Paginator which iterates over all CallFlows.

voice/callflow_test.go

@@ -2,7 +2,6 @@ package voice
 
 import (
 	"encoding/json"
-	"net/http"
 	"reflect"
 	"testing"
 	"time"
@@ -131,25 +130,86 @@ func TestCallFlowJSONUnmarshal(t *testing.T) {
 }
 
 func TestCreateCallFlow(t *testing.T) {
-	mbClient, stop := testRequest(http.StatusOK, []byte(`{
-		"data": [
-			{
-				"id": "the-id",
-				"title": "the-title",
-				"createdAt": "2018-01-29T13:46:06Z",
-				"updatedAt": "2018-01-30T16:00:34Z"
-			}
-		]
-	}`))
-	defer stop()
-	newCf := &CallFlow{}
+	mbClient, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	newCf := &CallFlow{
+		Title: "the-title",
+		Steps: []CallFlowStep{
+			&CallFlowSayStep{
+				Payload:  "Hello",
+				Language: "en-US",
+				Voice:    "male",
+			},
+			&CallFlowPauseStep{
+				Length: time.Second,
+			},
+		},
+	}
 	if err := newCf.Create(mbClient); err != nil {
 		t.Fatal(err)
 	}
-	if newCf.ID != "the-id" {
-		t.Fatalf("Unexpected ID: %q", newCf.ID)
-	}
 	if newCf.Title != "the-title" {
 		t.Fatalf("Unexpected Title: %q", newCf.Title)
 	}
+	if len(newCf.Steps) != 2 {
+		t.Fatalf("Unexpected Title: %q", newCf.Title)
+	}
+}
+
+func TestCallFlowByID(t *testing.T) {
+	mbClient, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	newCf := &CallFlow{
+		Title: "the-title",
+		Steps: []CallFlowStep{
+			&CallFlowHangupStep{},
+		},
+	}
+	if err := newCf.Create(mbClient); err != nil {
+		t.Fatal(err)
+	}
+
+	fetchedCf, err := CallFlowByID(mbClient, newCf.ID)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if fetchedCf.ID != newCf.ID {
+		t.Fatalf("mismatched fetched IDs: exp %q, got %q", newCf.ID, fetchedCf.ID)
+	}
+}
+
+func TestCallFlowList(t *testing.T) {
+	mbClient, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	for _, c := range []string{"foo", "bar", "baz"} {
+		newCf := &CallFlow{
+			Title: c,
+			Steps: []CallFlowStep{
+				&CallFlowHangupStep{},
+			},
+		}
+		if err := newCf.Create(mbClient); err != nil {
+			t.Fatal(err)
+		}
+	}
+
+	i := 0
+	for cf := range CallFlows(mbClient).Stream() {
+		if err, ok := cf.(error); ok {
+			t.Fatal(err)
+		}
+		i++
+	}
+	if i == 0 {
+		t.Fatal("no callflows were fetched")
+	}
 }

voice/webhook.go

@@ -79,11 +79,13 @@ func CreateWebHook(client *messagebird.Client, url, token string) (*Webhook, err
 		URL:   url,
 		Token: token,
 	}
-	wh := &Webhook{}
-	if err := client.Request(wh, http.MethodPost, apiRoot+"/webhooks/", data); err != nil {
+	var resp struct {
+		Data []Webhook `json:"data"`
+	}
+	if err := client.Request(&resp, http.MethodPost, apiRoot+"/webhooks/", data); err != nil {
 		return nil, err
 	}
-	return wh, nil
+	return &resp.Data[0], nil
 }
 
 // Update syncs hte local state of a webhook to the MessageBird API.

voice/webhook_test.go

@@ -0,0 +1,45 @@
+package voice
+
+import (
+	"testing"
+)
+
+func TestCreateWebhook(t *testing.T) {
+	mbClient, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	const url = "https://example.com/voice-webhook"
+	newWh, err := CreateWebHook(mbClient, url, "token")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if newWh.URL != url {
+		t.Fatalf("Unexpected URL: %q", newWh.URL)
+	}
+}
+
+func TestWebhookList(t *testing.T) {
+	mbClient, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	for _, c := range []string{"foo", "bar", "baz"} {
+		if _, err := CreateWebHook(mbClient, "https://example/com/"+c, "token"); err != nil {
+			t.Fatal(err)
+		}
+	}
+
+	i := 0
+	for cf := range Webhooks(mbClient).Stream() {
+		if err, ok := cf.(error); ok {
+			t.Fatal(err)
+		}
+		i++
+	}
+	if i == 0 {
+		t.Fatal("no webhooks were fetched")
+	}
+}