Add CardDAV (RFC 6352) support #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements CardDAV (RFC 6352) support for the dav-server library, following the same patterns as the existing CalDAV implementation. It adds vCard-based contact management capabilities alongside the existing calendar functionality.
Changes:
- Adds carddav feature flag with calcard dependency for vCard parsing and validation
- Implements MKADDRESSBOOK method and addressbook-query/addressbook-multiget REPORT types
- Adds CardDAV-specific properties (addressbook-home-set, supported-address-data) and metadata trait methods
- Refactors shared filter types (TextMatch, ParameterFilter) into dav_filters module for code reuse between CalDAV and CardDAV
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds carddav feature flag and calcard dependency |
| src/lib.rs | Exposes new carddav and dav_filters modules |
| src/dav_filters.rs | New shared module for TextMatch and ParameterFilter types used by both CalDAV and CardDAV |
| src/carddav.rs | Core CardDAV module with types, XML helpers, and vCard validation functions |
| src/handle_carddav.rs | Implements MKADDRESSBOOK method and REPORT handlers for addressbook queries |
| src/handle_caldav.rs | Updates CalDAV REPORT handler to route CardDAV requests and adds match_type field to TextMatch |
| src/caldav.rs | Removes duplicate TextMatch/ParameterFilter types, re-exports from dav_filters |
| src/handle_props.rs | Adds CardDAV property support in PROPFIND responses |
| src/handle_options.rs | Adds CardDAV compliance string and methods to OPTIONS responses |
| src/davhandler.rs | Routes MKADDRESSBOOK and REPORT methods based on feature flags |
| src/util.rs | Adds MkAddressbook to DavMethod enum |
| src/fs.rs | Adds is_addressbook trait method to DavMetaData |
| src/memfs.rs | Implements is_addressbook for MemFs and creates default addressbooks directory |
| src/localfs.rs | Implements is_addressbook for LocalFs and creates default addressbooks directory |
| src/localfs_macos.rs | Implements is_addressbook for EmptyMetaData (returns false) |
| tests/carddav_tests.rs | Comprehensive test suite for CardDAV functionality |
| tests/caldav_tests.rs | Updates REPORT test to handle conditional feature flags |
| examples/carddav.rs | Example CardDAV server using Axum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Implement CardDAV functionality following the same patterns as CalDAV: - Add carddav feature flag with calcard dependency for vCard parsing - Implement MKADDRESSBOOK method for creating address book collections - Add REPORT support for addressbook-query and addressbook-multiget - Add addressbook-home-set property for client discovery - Add supported-address-data property (vCard 3.0 and 4.0) - Implement is_addressbook() trait method for DavMetaData - Add CardDAV example server with Axum
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CardDAV functionality following the same patterns as CalDAV:
Totally vibe-coded.