Skip to content

Upgrade to Rust 2024 edition, replace lazy_static and jemallocator#129

Merged
messense merged 5 commits intomessense:mainfrom
miyayaLora:main
Jul 28, 2025
Merged

Upgrade to Rust 2024 edition, replace lazy_static and jemallocator#129
messense merged 5 commits intomessense:mainfrom
miyayaLora:main

Conversation

@miyayaLora
Copy link

  1. upgrade to Rust 2024 edition
  2. Rust 2024 corresponds to Rust version 1.85. In the standard library, there is std::sync::LazyLock, which is an alternative to lazy_static, and its main code comes from once_cell. Both once_cell and lazy_static have entered the maintenance stage. Using std::sync::LazyLock from the standard library is a good choice
  3. jemallocator is no longer maintained. Currently, in the Rust ecosystem, the fork version of tikv is mainly used. It should be migrated to tikv_jemallocator

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 32.72727% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.25%. Comparing base (279869d) to head (ee9a12e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
capi/src/lib.rs 13.95% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   84.26%   83.25%   -1.02%     
==========================================
  Files           9        9              
  Lines        1907     1750     -157     
==========================================
- Hits         1607     1457     -150     
+ Misses        300      293       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Performance Report

Merging #129 will not alter performance

Comparing lukingcathy:main (ee9a12e) with main (279869d)

Summary

✅ 12 untouched benchmarks

@messense
Copy link
Owner

rustfmt is failing.

Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 9910e6b into messense:main Jul 28, 2025
8 of 10 checks passed
@miyayaLora
Copy link
Author

Thank you for merging this pr. Is it convenient to push a new version to crates.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants