Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Maybe further refactor to a build.rs in jieba-rs's crate.
There was a problem hiding this comment.
Interesting.
Do you have some preference on these different methods? I personally consider that code generation in this case can be easy to debug and reduce an extra crate in the dep tree to maintain.
surrealdb/surrealdb#4556 (comment) looks weird. Clippy rules should not affect dependencies. And if they don't need certain features, opt-out the feature should opt-out the related code also.
There was a problem hiding this comment.
If they'd prefer include_str over fs, it's possible when using build.rs actually.
There was a problem hiding this comment.
I don't think it's clippy, they are using https://crates.io/crates/cargo-acl.
I don't have a strong preference here, both build.rs & proc macro have advantages and disadvantages. IMO the current proc maco impl does not use syn so compile time should be fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 83.25% 83.25%
=======================================
Files 9 9
Lines 1750 1750
=======================================
Hits 1457 1457
Misses 293 293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #130 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
cc @messense
I'd go through the codebase and pick up some issues to try them out. But first try to sort out the structure for further development.
What do you think?