Closed
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Dec 19, 2025
| pub mod tfidf; | ||
|
|
||
| pub static DEFAULT_STOP_WORDS: LazyLock<BTreeSet<String>> = LazyLock::new(|| { | ||
| pub fn default_stop_words() -> BTreeSet<String> { |
Contributor
Author
There was a problem hiding this comment.
Seems we always use clone. Then we may probably not expose it as a static state.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 83.34% 83.07% -0.27%
==========================================
Files 9 9
Lines 1759 1767 +8
==========================================
+ Hits 1466 1468 +2
- Misses 293 299 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #137 will not alter performanceComparing Summary
|
Owner
|
Just to confirm, the regex change will not regress #122? |
Contributor
Author
|
Now I get the reason we use thread-locals here. Let me bench it out. |
Contributor
Author
|
No. It is still relevant. Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @messense