Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the type of the doc_id parameter in the begin_tile method from Option<NonZero<i32>> to i32 to match the FFI layer's expectations.
- Changed the
doc_idparameter type fromOption<NonZero<i32>>toi32in allbegin_tilemethod signatures - Updated call sites to pass
doc_idas a plaini32instead of wrapping it withNonZero::new()or using.map_or()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/device/native.rs | Updated begin_tile method signature in the NativeDevice trait and its implementations for Box<T> and Rc<RefCell<T>>, and updated the FFI bridge to pass doc_id as plain i32 |
| src/device.rs | Updated begin_tile method signature and removed the map_or() call when passing doc_id to the FFI function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hm, I'm not quite sure what the intention is. I think they would want Maybe it's worth opening an issue against mupdf to ask about this oddity? |
No description provided.