Add half_precision condition to TensorConfig and refactor specdb tests #38
+65
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2025
meta-cla
bot
added
the
CLA Signed
|
@manuelcandales has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@manuelcandales has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@manuelcandales has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
digantdesai
reviewed
Aug 19, 2025
|
|
||
|
|
||
| class TestSpecDBOperationsCPU(BaseSpecDBTest): | ||
| """Test class for validating all specs in SpecDB using gen_errors on CPU.""" | ||
|
|
||
| SKIP_OPS = [ |
There was a problem hiding this comment.
all after including HALF_PRECISION?
digantdesai
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D80468300