Add outer platform interfaces and extract NVIDIA impls from opt_manager#110
Merged
Add outer platform interfaces and extract NVIDIA impls from opt_manager#110
Conversation
Introduce KernelVerifier, KernelBenchmarker, and WorkerRunner abstract interfaces that define the seams where platform-specific code enters OptimizationManager. Extract the existing NVIDIA-specific code (verification via VerificationWorker, benchmarking via Benchmark, worker spawning via mp.Process) into NvidiaVerifier, NvidiaBenchmarker, and NvidiaWorkerRunner classes that implement these interfaces. OptimizationManager now delegates to self.verifier, self.benchmarker, and self.worker_runner instead of inlining the NVIDIA code. No behavioral changes — the same NVIDIA defaults are always constructed.
meta-cla
bot
added
the
CLA Signed
kaiming-cheng
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
KernelVerifier,KernelBenchmarker, andWorkerRunnerabstract interfaces that define the seams where platform-specific code enters OptimizationManager.Extract the existing NVIDIA-specific code (verification via
VerificationWorker, benchmarking viaBenchmark, worker spawning viamp.Process) intoNvidiaVerifier,NvidiaBenchmarker, andNvidiaWorkerRunnerclasses that implement these interfaces.OptimizationManagernow delegates toself.verifier, self.benchmarker, and self.worker_runnerinstead of inlining the NVIDIA code. No behavioral changes — the same NVIDIA defaults are always constructed.