Add inner-worker platform interfaces and NVIDIA implementations#111
Merged
Jack-Khuu merged 1 commit intoplatform/outer-interfacesfrom Mar 3, 2026
Merged
Conversation
Add 5 worker-level abstract interfaces for components inside OptimizationWorker: AcceleratorSpecsProvider, KernelProfilerBase, RooflineAnalyzerBase, BottleneckAnalyzerBase, RAGPrescriberBase. Add NVIDIA wrapper implementations that lazily delegate to the existing concrete classes (KernelProfiler, RooflineAnalyzer, BottleneckAnalyzer, RAGPrescriber, get_gpu_specs). Add platform_components dict parameter to OptimizationWorker so registry-resolved components can be injected from the manager level. _init_components() checks platform_components before falling back to the default NVIDIA construction.
meta-cla
bot
added
the
CLA Signed
kaiming-cheng
approved these changes
Mar 3, 2026
Laurawly
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 5 worker-level abstract interfaces for components inside
OptimizationWorker:AcceleratorSpecsProvider,KernelProfilerBase,RooflineAnalyzerBase,BottleneckAnalyzerBase,RAGPrescriberBase.Add NVIDIA wrapper implementations that lazily delegate to the existing concrete classes (KernelProfiler, RooflineAnalyzer, BottleneckAnalyzer, RAGPrescriber, get_gpu_specs).
Add platform_components dict parameter to OptimizationWorker so registry-resolved components can be injected from the manager level.
_init_components()checks platform_components before falling back to the default NVIDIA construction.No behavioral changes — the same NVIDIA defaults are always constructed.
Note: Components added in
triton_kernel_agent/platform/nvidia.pycan be inlined in the future to reduce indirection. It is not done here to reduce the change complexity