-
Notifications
You must be signed in to change notification settings - Fork 115
Address code review feedback for MCP implementation #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rfc-003-first-pr
Are you sure you want to change the base?
Conversation
|
Hi @copilot! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Co-authored-by: Darktex <[email protected]>
Co-authored-by: Darktex <[email protected]>
Darktex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot see my feedback
| step_count=payload.get("step_count", 0), | ||
| ) | ||
|
|
||
| def list_tools(self) -> List[Dict[str, Any]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do the opposite: remove list_tools and echo_message as methods, and remove each and every reference to them
Fixes issues identified by automated code review on the MCP infrastructure PR.
http_server.py
hasattrguard before accessingmcp_clientto preventAttributeErroron non-MCP environmentstool_nameinCallToolActiondeserializationMCPEnvironmentimportjsonimportmcp_environment.py
mcp_clientkwarg fromsuper().__init__()(baseEnvironmentdoesn't accept it)client.py
list_tools()andecho_message()convenience methods (referenced in docstring but missing)ListToolsActionimportpyproject.toml
openenv_core.mcppackage reference (directory doesn't exist)RFC-003-implementation-journal.md
mcp_tools.pytomcp_server.py💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.