Upgrade fbcode/pytorch to Python Scientific Stack 2 #2584
Closed
+64
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64008689 |
igorsugak
added a commit
to igorsugak/opacus
that referenced
this pull request
Oct 18, 2024
Summary: X-link: meta-pytorch/captum#1387 X-link: meta-pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
igorsugak
added a commit
to igorsugak/opacus
that referenced
this pull request
Oct 18, 2024
Summary: X-link: meta-pytorch/captum#1387 X-link: meta-pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
igorsugak
added a commit
to igorsugak/captum
that referenced
this pull request
Oct 18, 2024
Summary: X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/captum#1387 X-link: pytorch/audio#3845 Differential Revision: D64008689
igorsugak
force-pushed
the
export-D64008689
branch
from
47dc19d to
a3907e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64008689 |
igorsugak
added a commit
to igorsugak/audio
that referenced
this pull request
Oct 18, 2024
…ytorch#3845) Summary: X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/captum#1387 X-link: meta-pytorch/botorch#2584 Differential Revision: D64008689
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17333 17340 +7
=======================================
+ Hits 17331 17338 +7
Misses 2 2 ☔ View full report in Codecov by Sentry. |
igorsugak
added a commit
to igorsugak/audio
that referenced
this pull request
Oct 18, 2024
…ch#3845) Summary: X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/captum#1387 X-link: meta-pytorch/botorch#2584 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
igorsugak
added a commit
to igorsugak/botorch
that referenced
this pull request
Oct 18, 2024
Summary: X-link: pytorch/audio#3846 X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/captum#1387 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
igorsugak
added a commit
to igorsugak/captum
that referenced
this pull request
Oct 18, 2024
Summary: X-link: pytorch/audio#3846 X-link: meta-pytorch/opacus#680 X-link: meta-pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
igorsugak
added a commit
to igorsugak/opacus
that referenced
this pull request
Oct 18, 2024
Summary: X-link: meta-pytorch/captum#1389 X-link: meta-pytorch/botorch#2586 X-link: pytorch/audio#3846 X-link: meta-pytorch/captum#1387 X-link: meta-pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
|
merged as #2586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64008689