Skip to content

Make FullyBayesian ABC more flexible again #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Make FullyBayesian ABC more flexible again #2872

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fb6da0
fea: make base class more flexible if users have more complex pyro mo…
CompRhys Jun 9, 2025
48a2e69
make the tests pass
CompRhys Aug 18, 2025
a852fe8
Merge branch 'main' into pyro-model-kwargs
CompRhys Aug 26, 2025
a87a8ba
Merge remote-tracking branch 'upstream/main' into pyro-model-kwargs
CompRhys Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions botorch/models/fully_bayesian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,7 @@ def __init__(
train_Yvar: Tensor | None = None,
outcome_transform: OutcomeTransform | None = None,
input_transform: InputTransform | None = None,
use_input_warping: bool = False,
indices_to_warp: list[int] = None,
pyro_model_kwargs: dict[str, Any] | None = None,
) -> None:
r"""Initialize the fully Bayesian single-task GP model.

Expand All @@ -662,9 +661,8 @@ def __init__(
instantiation of the model.
input_transform: An input transform that is applied in the model's
forward pass.
use_input_warping: A boolean indicating whether to use input warping.
indices_to_warp: An optional list of indices to warp. The default
is to warp all inputs.
pyro_model_kwargs: A dictionary of keyword arguments to pass to the
pyro model.
"""
if not (
train_X.ndim == train_Y.ndim == 2
Expand Down Expand Up @@ -704,10 +702,7 @@ def __init__(
self.mean_module = None
self.covar_module = None
self.likelihood = None
self.pyro_model = self._pyro_model_class(
use_input_warping=use_input_warping,
indices_to_warp=indices_to_warp,
)
self.pyro_model = self._pyro_model_class(**(pyro_model_kwargs or {}))
self.pyro_model.set_inputs(
train_X=transformed_X, train_Y=train_Y, train_Yvar=train_Yvar
)
Expand Down
Loading