-
Notifications
You must be signed in to change notification settings - Fork 445
Improve best feasible objective #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TobyBoyne
wants to merge
14
commits into
meta-pytorch:main
Choose a base branch
from
TobyBoyne:improve_best_feasible_objective
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4d024fb
Add `infeasible_obj` argument to qLogNEI
TobyBoyne 40623f5
Replace convex weighted samples with uniform samples in bounding box
TobyBoyne 670fbc6
Check upper and lower bound of posterior for objective evaluation
TobyBoyne e7e9520
Improve `prune_inferior_points` when all points are infeasible
TobyBoyne b145f06
Correct padding size
TobyBoyne 1e0625a
Extract std calculation from lb
TobyBoyne 28930fe
Merge branch 'main' into improve_best_feasible_objective
TobyBoyne 7a04f73
Change min to explicitly minimize the upper/lower bound first
TobyBoyne cfffbe2
Add warning message to `_prune_inferior_shared_processing` when all p…
TobyBoyne f768aab
Add test for no feasible points recommending ProbabilityOfFeasibility
TobyBoyne e3012c6
Remove `infeasible_obj` argument
TobyBoyne 1440623
Fix `min` and `max` functions not using `.values`
TobyBoyne db5303f
Move warning to `compute_best_feasible_objective`
TobyBoyne bc23e8f
Fix handling of dimensions for batched inputs
TobyBoyne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be added to
qNoisyExpectedImprovement
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - if the changes look good to whoever reviews, then I will also apply them to qNEI, as well as investigating q(Log)NEHVI too. Just wanted to get confirmation that the changes were good before making them elsewhere :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to remove this argument, since the issue is best resolved by using ProbabilityOfFeasibility.