Update fixed_features type hints and docstrings in OptimizeAcqfInputs (#3240)#3240
Closed
saitcakmak wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Update fixed_features type hints and docstrings in OptimizeAcqfInputs (#3240)#3240saitcakmak wants to merge 1 commit intometa-pytorch:mainfrom
saitcakmak wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this in D97314412. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3240 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 220 220
Lines 21850 21850
=======================================
Hits 21846 21846
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…meta-pytorch#3240) Summary: The fixed_features parameter in OptimizeAcqfInputs, optimize_acqf, and optimize_acqf_cyclic now documents that values can be float (fixed across the batch) or Tensor (different fixed values per batch element, for batched optimization with different fixed features per restart). Closes meta-pytorch#3111 Reviewed By: esantorella Differential Revision: D97314412 Pulled By: saitcakmak
meta-codesync
bot
changed the title
saitcakmak
force-pushed
the
fix/3111-optimize-acqf-inputs-typing
branch
from
cca54ce to
450e9f4
Compare
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97314412. |
|
@saitcakmak merged this pull request in 37de228. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The fixed_features parameter in OptimizeAcqfInputs, optimize_acqf, and optimize_acqf_cyclic now documents that values can be float (fixed across the batch) or Tensor (different fixed values per batch element, for batched optimization with different fixed features per restart).
Closes #3111
Reviewed By: esantorella
Differential Revision: D97314412
Pulled By: saitcakmak