program-data-separation demo #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.program-data-separation-example
branch
6 times, most recently
from
11059f6 to
bd2e5c2
Compare
lucylq
commented
Jul 17, 2025
lucylq
force-pushed
the
lfq.program-data-separation-example
branch
from
bd2e5c2 to
588ae93
Compare
| const char *data_path = FLAGS_data_path.c_str(); | ||
|
|
||
| // Load the model. | ||
| Module module(model_path, data_path); |
Contributor
There was a problem hiding this comment.
do we have support for swift and java bindings?
Contributor
Author
There was a problem hiding this comment.
I added support for java bindings in the LLM runner. Outside of that, I don't think there is support yet.
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #include <executorch/extension/module/module.h> |
Contributor
There was a problem hiding this comment.
Do we need to update this doc?
https://docs.pytorch.org/executorch/main/extension-module.html
Comment on lines
+103
to
+109
| with open(pte_file, "wb") as fp: | ||
| executorch_program.write_to_file(fp) | ||
| if executorch_program._tensor_data.get("_default_external_constant"): | ||
| executorch_program._tensor_data[model_name] = ( | ||
| executorch_program._tensor_data.pop("_default_external_constant") | ||
| ) | ||
| executorch_program.write_tensor_data_to_file(args.outdir) |
Contributor
There was a problem hiding this comment.
where are these AOT APIs document?
Contributor
There was a problem hiding this comment.
should we update this doc too?
https://docs.pytorch.org/executorch/main/using-executorch-export.html
Contributor
Author
There was a problem hiding this comment.
lucylq
force-pushed
the
lfq.program-data-separation-example
branch
from
588ae93 to
76175cd
Compare
mergennachin
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples on how to generate PTE, PTD files, and how to run them in ExecuTorch via Module.
Note: I created a separate ET submodule --> we need the changes from 0.7 for this. However, I'm not sure we should be creating a new submodule for each project.
Issue: pytorch/executorch#12215