Skip to content

Github CI run 360s timeout #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/samlurye/52/base
Choose a base branch
from
Open

Github CI run 360s timeout #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/tests/test_proc_mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ async def call_on_other_mesh(self, actor: "TestActor") -> ValueMesh[int]:
return await actor.get_rank_plus_init_value.call()


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_proc_mesh_initialization() -> None:
host = create_local_host_mesh("test_host")
proc_mesh = host.spawn_procs(name="test_proc")
# Test that initialization completes successfully
assert await proc_mesh.initialized


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_proc_mesh_spawn_single_actor() -> None:
host = create_local_host_mesh("test_host")
proc_mesh = host.spawn_procs(name="test_proc")
Expand All @@ -78,7 +78,7 @@ def test_proc_mesh_spawn_single_actor() -> None:
assert actor.get_value.call_one().get() == 43


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_proc_mesh_multi_actor() -> None:
host = create_local_host_mesh("multi_host", Extent(["replicas", "hosts"], [2, 2]))
proc_mesh = host.spawn_procs(name="test_proc", per_host={"gpus": 3})
Expand All @@ -92,7 +92,7 @@ def test_proc_mesh_multi_actor() -> None:
assert point.rank == i


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_proc_mesh_sliced() -> None:
host = create_local_host_mesh("multi_host", Extent(["replicas", "hosts"], [2, 2]))
proc_mesh = host.spawn_procs(name="test_proc", per_host={"gpus": 3})
Expand Down
58 changes: 29 additions & 29 deletions python/tests/test_python_actors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def get_this_proc(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_choose(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
v = proc.spawn("counter", Counter, 3)
Expand All @@ -160,7 +160,7 @@ async def test_choose(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_stream(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
v = proc.spawn("counter2", Counter, 3)
Expand All @@ -182,7 +182,7 @@ async def fetch(self, to: To):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_mesh_passed_to_mesh(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
f = proc.spawn("from", From)
Expand All @@ -193,7 +193,7 @@ async def test_mesh_passed_to_mesh(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_mesh_passed_to_mesh_on_different_proc_mesh(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
proc2 = spawn_procs_on_fake_host(v1, {"gpus": 2})
Expand All @@ -205,7 +205,7 @@ async def test_mesh_passed_to_mesh_on_different_proc_mesh(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_actor_slicing(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
proc2 = spawn_procs_on_fake_host(v1, {"gpus": 2})
Expand All @@ -222,7 +222,7 @@ def test_actor_slicing(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_aggregate(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
counter = proc.spawn("counter", Counter, 1)
Expand All @@ -243,7 +243,7 @@ async def return_current_rank_str(self):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_rank_size(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
r = proc.spawn("runit", RunIt)
Expand All @@ -255,7 +255,7 @@ async def test_rank_size(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_rank_string(v1: bool):
if v1:
per_host = {"gpus": 2}
Expand All @@ -277,7 +277,7 @@ def sync_endpoint(self, a_counter: Counter):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_sync_actor(v1: bool):
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
a = proc.spawn("actor", SyncActor)
Expand All @@ -287,7 +287,7 @@ async def test_sync_actor(v1: bool):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_sync_actor_sync_client(v1: bool) -> None:
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
a = proc.spawn("actor", SyncActor)
Expand All @@ -297,14 +297,14 @@ def test_sync_actor_sync_client(v1: bool) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_proc_mesh_size(v1: bool) -> None:
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
assert 2 == proc.size("gpus")


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_rank_size_sync(v1: bool) -> None:
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
r = proc.spawn("runit", RunIt)
Expand All @@ -315,7 +315,7 @@ def test_rank_size_sync(v1: bool) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_accumulate_sync(v1: bool) -> None:
proc = spawn_procs_on_fake_host(v1, {"gpus": 2})
counter = proc.spawn("counter", Counter, 1)
Expand All @@ -332,7 +332,7 @@ def doit(self, c: Counter):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_value_mesh(v1: bool) -> None:
if v1:
per_host = {"gpus": 2}
Expand All @@ -349,7 +349,7 @@ def test_value_mesh(v1: bool) -> None:
assert list(x) == n.slice(gpus=0).doit.call_one(counter).get()


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_rust_binding_modules_correct() -> None:
"""
This tests that rust bindings will survive pickling correctly.
Expand Down Expand Up @@ -378,7 +378,7 @@ def check(module, path):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_proc_mesh_liveness(v1: bool) -> None:
mesh = spawn_procs_on_this_host(v1, {"gpus": 2})
counter = mesh.spawn("counter", Counter, 1)
Expand Down Expand Up @@ -414,7 +414,7 @@ async def get_async(self):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_actor_tls(v1: bool) -> None:
"""Test that thread-local state is respected."""
pm = spawn_procs_on_this_host(v1, {"gpus": 1})
Expand Down Expand Up @@ -445,7 +445,7 @@ def get_value(self):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_actor_tls_full_sync(v1: bool) -> None:
"""Test that thread-local state is respected."""
pm = spawn_procs_on_this_host(v1, {"gpus": 1})
Expand Down Expand Up @@ -473,7 +473,7 @@ async def no_more(self) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_async_concurrency(v1: bool):
"""Test that async endpoints will be processed concurrently."""
pm = spawn_procs_on_this_host(v1, {})
Expand Down Expand Up @@ -611,7 +611,7 @@ def _handle_undeliverable_message(


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_actor_log_streaming(v1: bool) -> None:
# Save original file descriptors
original_stdout_fd = os.dup(1) # stdout
Expand Down Expand Up @@ -876,7 +876,7 @@ def _stream_logs(self) -> bool:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_logging_option_defaults(v1: bool) -> None:
# Save original file descriptors
original_stdout_fd = os.dup(1) # stdout
Expand Down Expand Up @@ -1155,7 +1155,7 @@ async def test_flush_logs_fast_exit() -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_flush_on_disable_aggregation(v1: bool) -> None:
"""Test that logs are flushed when disabling aggregation.

Expand Down Expand Up @@ -1280,7 +1280,7 @@ async def test_multiple_ongoing_flushes_no_deadlock(v1: bool) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_adjust_aggregation_window(v1: bool) -> None:
"""Test that the flush deadline is updated when the aggregation window is adjusted.

Expand Down Expand Up @@ -1371,7 +1371,7 @@ async def send(self, port: Port[int]):


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_port_as_argument(v1: bool) -> None:
proc_mesh = spawn_procs_on_fake_host(v1, {"gpus": 1})
s = proc_mesh.spawn("send_alot", SendAlot)
Expand Down Expand Up @@ -1483,7 +1483,7 @@ def add(self, port: "Port[int]", b: int) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_ported_actor(v1: bool):
proc_mesh = spawn_procs_on_fake_host(v1, {"gpus": 1})
a = proc_mesh.spawn("port_actor", PortedActor)
Expand All @@ -1499,7 +1499,7 @@ async def consume():
assert r == (7, 2, 3)


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_python_task_tuple() -> None:
PythonTask.from_coroutine(consume()).block_on()

Expand Down Expand Up @@ -1568,7 +1568,7 @@ def _handle_undeliverable_message(


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_undeliverable_message_with_override(v1: bool) -> None:
pm = spawn_procs_on_this_host(v1, {"gpus": 1})
receiver = pm.spawn("undeliverable_receiver", UndeliverableMessageReceiver)
Expand All @@ -1584,7 +1584,7 @@ async def test_undeliverable_message_with_override(v1: bool) -> None:


@pytest.mark.parametrize("v1", [True, False])
@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
async def test_undeliverable_message_without_override(v1: bool) -> None:
pm = spawn_procs_on_this_host(v1, {"gpus": 1})
sender = pm.spawn("undeliverable_sender", UndeliverableMessageSender)
Expand Down Expand Up @@ -1659,7 +1659,7 @@ async def spawning_from_endpoint(self, name, root) -> None:
await get_or_spawn_controller(name, SpawningActorFromEndpointActor, root=root)


@pytest.mark.timeout(60)
@pytest.mark.timeout(360)
def test_get_or_spawn_controller_inside_actor_endpoint():
actor_1 = get_or_spawn_controller("actor_1", SpawningActorFromEndpointActor).get()
actor_1.spawning_from_endpoint.call_one("actor_2", root="actor_1").get()
Expand Down
Loading