[monarch] monarch.actor.configure, configure default transport anywhere, wire up v1 controllers #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re, wire up v1 controllers This diff does a few things: - Introduce the `monarch.actor.configure` public API, which just wraps `monarch._rust_bindings.monarch_hyperactor.config.configure` function - Update the behavior of `global_root_client()` so that the client proc/instance are re-initialized whenever the default transport changes. - Supporting this also required updating `monarch.actor.context()` to allow overriding the current value of the `_context` contextvar if it is called from the root client and the default transport changed. It also requires forcibly respawning the `_controller_controller` when this happens. - Make sure we pass `_attach_controller_controller=True` when a spawning a proc mesh from v1 `HostMesh` - Fix the v1 implementation of `get_or_spawn_controller` Differential Revision: [D84015780](https://our.internmc.facebook.com/intern/diff/D84015780/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84015780/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 6, 2025
…re, wire up v1 controllers This diff does a few things: - Introduce the `monarch.actor.configure` public API, which just wraps `monarch._rust_bindings.monarch_hyperactor.config.configure` function - Update the behavior of `global_root_client()` so that the client proc/instance are re-initialized whenever the default transport changes. - Supporting this also required updating `monarch.actor.context()` to allow overriding the current value of the `_context` contextvar if it is called from the root client and the default transport changed. It also requires forcibly respawning the `_controller_controller` when this happens. - Make sure we pass `_attach_controller_controller=True` when a spawning a proc mesh from v1 `HostMesh` - Fix the v1 implementation of `get_or_spawn_controller` Differential Revision: [D84015780](https://our.internmc.facebook.com/intern/diff/D84015780/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84015780/)! ghstack-source-id: 314421176 Pull Request resolved: #1446
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff does a few things:
monarch.actor.configurepublic API, which just wrapsmonarch._rust_bindings.monarch_hyperactor.config.configurefunctionglobal_root_client()so that the client proc/instance are re-initialized whenever the default transport changes.monarch.actor.context()to allow overriding the current value of the_contextcontextvar if it is called from the root client and the default transport changed. It also requires forcibly respawning the_controller_controllerwhen this happens._attach_controller_controller=Truewhen a spawning a proc mesh from v1HostMeshget_or_spawn_controllerDifferential Revision: D84015780
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!