Allow procs to skip forwarder when talking to peers #1449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ProcState::Running will now store 2 fields for addresses.
addr
is just any address that can be used to reach this Proc meaning it may be a proxy whilelocal_addr
is the true address in which it is running. When building address books during ProcMesh initialization, what we will do is for every MeshAgent, we will pass in a slightly modified address book where the address for every one of it's peers that share the same forwarding proxy is pointed towards the true direct address, while every other proc id is bound to that proc's forwarder address, so inter-host communication will still be through a proxy.That is for proc 2a, instead of being passed:
It will receive
The reason why we want to do this is because without it, the forwarder acts as a bottleneck within the host, and causes all communication to be serial instead of parallel.
Some example data points for perf improvement include:
Proof of parallelism (VPN needed): https://interncache-all.fbcdn.net/manifold/perfetto-artifacts/tree/ui/index.html#!/?url=https://interncache-all.fbcdn.net/manifold/perfetto_internal_traces%2Ftree%2Fshared_trace%2Fthomasywang_2070d1f3-3b42-48cd-bde1-20460b3850cf_tmpt17nblpf.json
Differential Revision: D84032776