: config: global: change layer rep in readiness for stacked test overrides #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84072524. |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 7, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Differential Revision: D84072524
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 7, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Differential Revision: D84072524
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 7, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Differential Revision: D84072524
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
shayne-fletcher
force-pushed
the
export-D84072524
branch
from
42dd657 to
413cf98
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
Summary: this diff follows on from the discussions in D83778023 and lands `ConfigAttr` and the unified `CONFIG` meta-attribute for marking configuration keys, replaces all previous `CONFIG_ENV_VAR`/`PYTHON_CONFIG_KEY` usage, and narrows `attrs()` and `init_from_env()` to include only keys carrying this meta. it updates monarch python bindings to read `py_name` from `ConfigAttr`, rewrites affected documentation accordingly, and adds a unit test verifying that non-`CONFIG` keys are excluded from `attrs()`. all existing keys in hyperactor and hyperactor\_mesh have been migrated to the new form. Reviewed By: mariusae, pablorfb-meta Differential Revision: D83997813
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
shayne-fletcher
force-pushed
the
export-D84072524
branch
from
413cf98 to
040b142
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
|
This pull request has been merged in 8830a56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
relates to part 2 of the refactors discussed in D83778023
refactor(config/global.rs): introduce
Layerenum and recover testsLayerrepresentation fromstruct+Sourcetoenumwith variants:File,Env,Runtime, andTestOverride { attrs, stacks }.layer_attrs,layer_attrs_mut,test_override_index).Dropimpls forConfigValueGuardandConfigLockto compile and preserve all existing behavior.all unit tests pass; ready for semantic refactor of
TestOverridelogic next.Differential Revision: D84072524