: config: global: robust to drop order in test overrides #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84085259. |
shayne-fletcher
force-pushed
the
export-D84085259
branch
from
1ffac3c to
a233b4c
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 7, 2025
…h#1457) Summary: Pull Request resolved: meta-pytorch#1457 Differential Revision: D84085259
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 7, 2025
…h#1457) Summary: `override_key` now pushes frames onto a per-key stack with unique tokens, allowing out-of-order drops and deterministic restoration. `ConfigValueGuard::drop` pops the active frame, restores the previous or default value, and updates the mirrored env var only when the top changes. `ensure_test_override_layer_mut` removed as redundant. `Key::name` moved to an unconstrained impl to relax the `Named` bound. adds tests verifying LIFO restoration and stability under out-of-order drops, covering both attrs and env behavior. Differential Revision: D84085259
shayne-fletcher
force-pushed
the
export-D84085259
branch
from
a233b4c to
40fee8d
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…h#1457) Summary: `override_key` now pushes frames onto a per-key stack with unique tokens, allowing out-of-order drops and deterministic restoration. `ConfigValueGuard::drop` pops the active frame, restores the previous or default value, and updates the mirrored env var only when the top changes. `ensure_test_override_layer_mut` removed as redundant. `Key::name` moved to an unconstrained impl to relax the `Named` bound. adds tests verifying LIFO restoration and stability under out-of-order drops, covering both attrs and env behavior. Reviewed By: mariusae Differential Revision: D84085259
shayne-fletcher
force-pushed
the
export-D84085259
branch
from
40fee8d to
4ae8f20
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…h#1457) Summary: `override_key` now pushes frames onto a per-key stack with unique tokens, allowing out-of-order drops and deterministic restoration. `ConfigValueGuard::drop` pops the active frame, restores the previous or default value, and updates the mirrored env var only when the top changes. `ensure_test_override_layer_mut` removed as redundant. `Key::name` moved to an unconstrained impl to relax the `Named` bound. adds tests verifying LIFO restoration and stability under out-of-order drops, covering both attrs and env behavior. Reviewed By: mariusae Differential Revision: D84085259
shayne-fletcher
force-pushed
the
export-D84085259
branch
2 times, most recently
from
af81a18 to
d3408cd
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 9, 2025
…h#1457) Summary: `override_key` now pushes frames onto a per-key stack with unique tokens, allowing out-of-order drops and deterministic restoration. `ConfigValueGuard::drop` pops the active frame, restores the previous or default value, and updates the mirrored env var only when the top changes. `ensure_test_override_layer_mut` removed as redundant. `Key::name` moved to an unconstrained impl to relax the `Named` bound. adds tests verifying LIFO restoration and stability under out-of-order drops, covering both attrs and env behavior. Reviewed By: mariusae Differential Revision: D84085259
Summary: this diff follows on from the discussions in D83778023 and lands `ConfigAttr` and the unified `CONFIG` meta-attribute for marking configuration keys, replaces all previous `CONFIG_ENV_VAR`/`PYTHON_CONFIG_KEY` usage, and narrows `attrs()` and `init_from_env()` to include only keys carrying this meta. it updates monarch python bindings to read `py_name` from `ConfigAttr`, rewrites affected documentation accordingly, and adds a unit test verifying that non-`CONFIG` keys are excluded from `attrs()`. all existing keys in hyperactor and hyperactor\_mesh have been migrated to the new form. Reviewed By: mariusae, pablorfb-meta Differential Revision: D83997813
…rides (meta-pytorch#1456) Summary: relates to part 2 of the refactors discussed in D83778023 refactor(config/global.rs): introduce `Layer` enum and recover tests - switch `Layer` representation from `struct`+`Source` to `enum` with variants: `File`, `Env`, `Runtime`, and `TestOverride { attrs, stacks }`. - updated helpers (`layer_attrs`, `layer_attrs_mut`, `test_override_index`). - adjusted `Drop` impls for `ConfigValueGuard` and `ConfigLock` to compile and preserve all existing behavior. all unit tests pass; ready for semantic refactor of `TestOverride` logic next. Reviewed By: mariusae Differential Revision: D84072524
…h#1457) Summary: `override_key` now pushes frames onto a per-key stack with unique tokens, allowing out-of-order drops and deterministic restoration. `ConfigValueGuard::drop` pops the active frame, restores the previous or default value, and updates the mirrored env var only when the top changes. `ensure_test_override_layer_mut` removed as redundant. `Key::name` moved to an unconstrained impl to relax the `Named` bound. adds tests verifying LIFO restoration and stability under out-of-order drops, covering both attrs and env behavior. Reviewed By: mariusae Differential Revision: D84085259
shayne-fletcher
force-pushed
the
export-D84085259
branch
from
d3408cd to
6f479d3
Compare
|
This pull request has been merged in 052e78f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D84085259