Replicate logs via bin/sh tee + FileLogMonitor #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently Monarch sits in the middle of log forwarding, ie if Monarch crashes a child proc's logs would be lost. Here we add `LogFileMonitor`, which will be the replacement for `LogFileWriter` and `LogTailer`. `LogFileMonitor` enables "process spawners" to attach the monitor to specific files (e.g. a custom file where stdout/stderr are teed), which propagates updates to the provided `log_channel`. This will effectively move Monarch out of the critical path for logging, more context on [doc](https://docs.google.com/document/d/1TSrsFqlXRPEhKOyQhTKd1XyY9JrjLH6y_Z5iGnrnzBo/edit?tab=t.0#heading=h.vvg43v4o545o) - Enables creation of temp log files - Adds a file watcher that propagates updates on file modifications - Add missing logging tests Differential Revision: D84111031
Differential Revision: D83786242
|
@pablorfb-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83786242. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D83786242