-
Notifications
You must be signed in to change notification settings - Fork 107
systemd prototyping #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shayne-fletcher
wants to merge
1
commit into
meta-pytorch:main
Choose a base branch
from
shayne-fletcher:export-D87582955
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
systemd prototyping #1960
shayne-fletcher
wants to merge
1
commit into
meta-pytorch:main
from
shayne-fletcher:export-D87582955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87582955. |
f3b3751 to
555c9e2
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 21, 2025
Summary: Pull Request resolved: meta-pytorch#1960 Differential Revision: D87582955
555c9e2 to
1f6d6c1
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 21, 2025
Summary: Pull Request resolved: meta-pytorch#1960 Differential Revision: D87582955
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 21, 2025
Summary: Pull Request resolved: meta-pytorch#1960 Differential Revision: D87582955
b467b85 to
69092fd
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 21, 2025
Summary: this is research into using systemd to manage transient units and surface their output. this change wires up an optional systemd feature in hyperactor_mesh and teaches BUCK to build with that feature. GitHub / OSS builds never enable the feature and so avoid depending on libsystemd being present on the runners. in rust, src/systemd.rs gains more transient units tests: experiments with log aggregation. the journald-based test is gated on `target_os = "linux"` and the `systemd` feature and then soft-fails if the journal or D-Bus session aren't available; this reflects the reality that GitHub CI and Meta devgpu/devvm journal configuration don't let us rely on that path. in response, this diff explores a more robust approach where units write to file descriptors we pass in over D-Bus (via `UnixStream::pair` and `Fd`), and we aggregate logs from one or many units in-process using async readers. this gives us a workable story for "systemd for unit management, Unix sockets for log transport" even where journald isn't practically usable. Differential Revision: D87582955
Summary: this is research into using systemd to manage transient units and surface their output. this change wires up an optional systemd feature in hyperactor_mesh and teaches BUCK to build with that feature. GitHub / OSS builds never enable the feature and so avoid depending on libsystemd being present on the runners. in rust, src/systemd.rs gains more transient units tests: experiments with log aggregation. the journald-based test is gated on `target_os = "linux"` and the `systemd` feature and then soft-fails if the journal or D-Bus session aren't available; this reflects the reality that GitHub CI and Meta devgpu/devvm journal configuration don't let us rely on that path. in response, this diff explores a more robust approach where units write to file descriptors we pass in over D-Bus (via `UnixStream::pair` and `Fd`), and we aggregate logs from one or many units in-process using async readers. this gives us a workable story for "systemd for unit management, Unix sockets for log transport" even where journald isn't practically usable. Differential Revision: D87582955
69092fd to
b1819ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D87582955