Allow disallowed time methods #1974
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87664116. |
meta-cla
bot
added
the
CLA Signed
thomasywang
force-pushed
the
export-D87664116
branch
from
70bb06d to
e68c7c0
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 24, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Differential Revision: D87664116
thomasywang
force-pushed
the
export-D87664116
branch
from
e68c7c0 to
0ca9b6f
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 24, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
thomasywang
force-pushed
the
export-D87664116
branch
from
0ca9b6f to
ad00a87
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 25, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 25, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 25, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 25, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Nov 25, 2025
Summary: We disallow methods relating to time to ensure that we use `hyperactor::clock`, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to use `hyperactor::clock` Reviewed By: shayne-fletcher, dulinriley Differential Revision: D87664116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We disallow methods relating to time to ensure that we use
hyperactor::clock, but need to make an exception for this for telemetry because we would create a circular dependency if we tried to usehyperactor::clockDifferential Revision: D87664116