Set LocalAlloc's transport to be Local #1981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I notice channels served from `LocalAlloc` is using metatls. I guess that is because by default it gets the transport from the input spec, which contains metatls: https://www.internalfb.com/code/fbsource/[056940bb1cd57f5dc7702498a081c26f58c1e7ba]/fbcode/monarch/hyperactor_mesh/src/alloc/local.rs?lines=132-133%2C150 This diffs explicitly set `LocalAlloc`'s transport to be `Local`, so it would not use the default impl, i.e. the spec's transport instead: https://www.internalfb.com/code/fbsource/[f46af006d39e28c30ccd00afb81e576c995a831f]/fbcode/monarch/hyperactor_mesh/src/alloc.rs?lines=327%2C349-352 Differential Revision: D84851977
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I notice channels served from
LocalAllocis using metatls. I guess that is because by default it gets the transport from the input spec, which contains metatls:https://www.internalfb.com/code/fbsource/[056940bb1cd57f5dc7702498a081c26f58c1e7ba]/fbcode/monarch/hyperactor_mesh/src/alloc/local.rs?lines=132-133%2C150
This diffs explicitly set
LocalAlloc's transport to beLocal, so it would not use the default impl, i.e. the spec's transport instead:https://www.internalfb.com/code/fbsource/[f46af006d39e28c30ccd00afb81e576c995a831f]/fbcode/monarch/hyperactor_mesh/src/alloc.rs?lines=327%2C349-352
Differential Revision: D84851977