: python/tests/test_actors.py: more contextmgr improvements #1982
+561
−339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87795973. |
meta-cla
bot
added
the
CLA Signed
shayne-fletcher
force-pushed
the
export-D87795973
branch
from
282e48f to
7ef1e51
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 24, 2025
…orch#1982) Summary: this refactors the Python-side config helpers so `configured()` actually behaves like a "save/restore Runtime overrides" wrapper instead of copying the merged config back into the Runtime layer. it introduces Runtime-only helpers and rewrites `configured()` / `configured_with_redirected_stdio()` to snapshot and restore just the Runtime layer while composing cleanly with stdio redirection. the logging semantics and test expectations are unchanged; only the way we stage and clean up runtime overrides is different (and now deterministic / nestable). Differential Revision: D87795973
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 24, 2025
…orch#1982) Summary: this refactors the Python-side config helpers so `configured()` actually behaves like a "save/restore Runtime overrides" wrapper instead of copying the merged config back into the Runtime layer. it introduces Runtime-only helpers and rewrites `configured()` / `configured_with_redirected_stdio()` to snapshot and restore just the Runtime layer while composing cleanly with stdio redirection. the logging semantics and test expectations are unchanged; only the way we stage and clean up runtime overrides is different (and now deterministic / nestable). Differential Revision: D87795973
shayne-fletcher
force-pushed
the
export-D87795973
branch
from
7ef1e51 to
967f1d1
Compare
…orch#1982) Summary: this refactors the Python-side config helpers so `configured()` actually behaves like a "save/restore Runtime overrides" wrapper instead of copying the merged config back into the Runtime layer. it introduces Runtime-only helpers and rewrites `configured()` / `configured_with_redirected_stdio()` to snapshot and restore just the Runtime layer while composing cleanly with stdio redirection. the logging semantics and test expectations are unchanged; only the way we stage and clean up runtime overrides is different (and now deterministic / nestable). Differential Revision: D87795973
shayne-fletcher
force-pushed
the
export-D87795973
branch
from
967f1d1 to
8fd5c66
Compare
|
This pull request has been merged in c98cade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this refactors the python-side config helpers to make Runtime-layer overrides explicit and reversible, replaces the previous "restore from snapshot" approach with a clearer model that writes into the Runtime layer on entry and clears it on exit, and exposes a Rust-backed
clear()to support that. the main functional change is addingconfigured_with_redirected_stdio(), which composes configuration overrides with stdio redirection in a single context manager so the tests don't need nested with blocks. all affected tests are updated to use the combined form, but the underlying logging behaviour is unchanged.Differential Revision: D87795973