Skip to content

Fix CQS signal F811 in fbcode/monarch/python/monarch/controller #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CQS signal F811 in fbcode/monarch/python/monarch/controller #1983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/monarch/controller/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from typing import Generator, List, NamedTuple, Optional, Sequence, Tuple, Union

from monarch._rust_bindings.monarch_extension.client import ( # @manual=//monarch/monarch_extension:monarch_extension
DebuggerMessage,
DebuggerMessage as RustDebuggerMessage,
WorldState,
)

Expand Down Expand Up @@ -79,7 +79,7 @@ def _read_messages(
for rank, value in self._backend.recvready(timeout):
yield from self._handle_message(rank, value)

def drain_and_stop(self) -> List[MessageResult | LogMessage | DebuggerMessage]:
def drain_and_stop(self) -> List[MessageResult | LogMessage | RustDebuggerMessage]:
messages = []
while self._messages:
messages.append(self._messages.popleft())
Expand Down
Loading