Remove torch-op special call path in tensor engine #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the work to remove a direct libtorch dependency. We now just route through python. A few months ago we tested that this is not slower because of so much wrapping/unwrapping to python objects anyway. We can re-enable faster execution in the future if needed. Differential Revision: [D87807456](https://our.internmc.facebook.com/intern/diff/D87807456/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87807456/)! [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
This is part of the work to remove a direct libtorch dependency. We now just route through python. A few months ago we tested that this is not slower because of so much wrapping/unwrapping to python objects anyway. We can re-enable faster execution in the future if needed. Differential Revision: [D87807456](https://our.internmc.facebook.com/intern/diff/D87807456/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87807456/)! [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is part of the work to remove a direct libtorch dependency. We now just route through python. A few months ago we tested that this is not slower because of so much wrapping/unwrapping to python objects anyway. We can re-enable faster execution in the future if needed.
Differential Revision: D87807456
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!