Move casting protocol into rust #851
Closed
+516
−583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 13, 2025
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) ghstack-source-id: 302731839 Pull Request resolved: #851
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 13, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 302743564 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 13, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 302748010 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 13, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 302759496 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 13, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 302760277 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 14, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 303021421 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 14, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 303110512 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 15, 2025
Pull Request resolved: #851 This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send. ghstack-source-id: 303184134 Differential Revision: [D80037834](https://our.internmc.facebook.com/intern/diff/D80037834/)
|
This pull request was exported from Phabricator. Differential Revision: D80037834 |
|
This pull request has been merged in cce99fb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This moves the logic for deferring sends into Rust to avoid slowing down actor sends. Increases send throughput ~30% from the python approach. It is just a little faster than what came before the python approach because this also eliminates a layer of python wrappers for dispatching sends. I suspect there is tons more to to be gained removing more layers of python between the user calling an endpoint and issuing a send.
Differential Revision: D80037834