Skip to content

[serde_multipart] serializable Message #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/mariusae/38/base
Choose a base branch
from

Conversation

mariusae
Copy link
Member

@mariusae mariusae commented Aug 13, 2025

Stack from ghstack (oldest at bottom):

We want to be able to (efficiently) serialize Message, passing through its constituent parts; and also to treat the message body as its own part.

In this change, we derive Serialize for Message, and convert its body into a Part.

Differential Revision: D80179921

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part.

In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`.

Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Aug 13, 2025
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part.

In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`.

Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)!

ghstack-source-id: 302736715
Pull Request resolved: #852
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 13, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80179921

We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part.

In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`.

Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80179921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants