Add preset to VideoEncoder API #1037
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
presetas an option in the VideoEncoder API.To review just these changes, see 2a49a3d.
Preset is a readable string in
libx264, so the docstring suggests those strings. Occasionally (as in the case of thelibsvtav1codec),presetcan be an int, so both types are accepted.To test,
test_video_encoder_against_ffmpeg_cliis updated to try combinations ofpixel_format,crf, andpreset.