Skip to content

Conversation

@Dan-Flores
Copy link
Contributor

@Dan-Flores Dan-Flores commented Nov 11, 2025

This PR adds preset as an option in the VideoEncoder API.
To review just these changes, see 2a49a3d.

Preset is a readable string in libx264, so the docstring suggests those strings. Occasionally (as in the case of the libsvtav1 codec), preset can be an int, so both types are accepted.

To test, test_video_encoder_against_ffmpeg_cli is updated to try combinations of pixel_format, crf, and preset.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 11, 2025
@Dan-Flores Dan-Flores closed this Nov 12, 2025
@Dan-Flores Dan-Flores deleted the preset_encode_option branch November 12, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant