Skip to content

Improve load_torchcodec_shared_libraries error reporting #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

Improve load_torchcodec_shared_libraries error reporting #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/torchcodec/_core/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io
import json
import warnings
import traceback
from types import ModuleType
from typing import List, Optional, Tuple, Union

Expand Down Expand Up @@ -58,11 +59,9 @@ def load_torchcodec_shared_libraries():
)
return ffmpeg_major_version, core_library_path
except Exception as e:
# TODO: recording and reporting exceptions this way is OK for now as it's just for debugging,
# but we should probably handle that via a proper logging mechanism.
exceptions.append((ffmpeg_major_version, e))
exceptions.append((ffmpeg_major_version, traceback.format_exc()))

traceback = (
full_traceback = (
"\n[start of libtorchcodec loading traceback]\n"
+ "\n".join(f"FFmpeg version {v}: {str(e)}" for v, e in exceptions)
+ "\n[end of libtorchcodec loading traceback]."
Expand All @@ -78,7 +77,7 @@ def load_torchcodec_shared_libraries():
3. Another runtime dependency; see exceptions below.
The following exceptions were raised as we tried to load libtorchcodec:
"""
f"{traceback}"
f"{full_traceback}"
)


Expand Down