Use CUDA and stable APIs instead of at::cuda#1238
Merged
NicolasHug merged 7 commits intometa-pytorch:mainfrom Feb 13, 2026
Merged
Use CUDA and stable APIs instead of at::cuda#1238NicolasHug merged 7 commits intometa-pytorch:mainfrom
NicolasHug merged 7 commits intometa-pytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1238
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cc26833 with merge base 6f10da0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Feb 12, 2026
mollyxu
approved these changes
Feb 12, 2026
Dan-Flores
reviewed
Feb 12, 2026
src/torchcodec/_core/CUDACommon.h
Outdated
| #include <cuda_runtime.h> | ||
| #include <npp.h> | ||
| #include <torch/types.h> | ||
| #include <torch/csrc/inductor/aoti_torch/c/shim.h> |
Contributor
There was a problem hiding this comment.
I was surprised to see this file was not in the torch/csrc/stable folder as other includes have been, but the source code does indicate that it is the stable API.
Contributor
Author
There was a problem hiding this comment.
Great observation! I was surprised as well, but this is what is recommended from the docs, and I recently confirmed with Jane that this file is OK and safe to include long-term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.