Make ffmpeg build workflow execute when script changes #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
force-pushed
the
ffmpeg_build
branch
2 times, most recently
from
00ef15d to
6823d64
Compare
NicolasHug
approved these changes
Oct 28, 2024
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Approving to unblock but let's make sure we can still trigger it manually (we can merge the PR now and then verify and fix later if needed)
| upload-artifact: ffmpeg-lgpl | ||
| repository: pytorch/torchcodec | ||
| runner: "${{ matrix.runner }}" | ||
| runner: macos-14-xlarge |
Contributor
There was a problem hiding this comment.
Q - what's the reason for changing the worker?
Contributor
Author
There was a problem hiding this comment.
To avoid the long macos-m1-stable queue. This is a GitHub hosted runner that seems to get a worker faster. I have a lot of difficulty getting a straight-forward answer to what Mac runners are arm64 versus x86, but this blog post indicates that macos-14-xlarge is arm64 (M1): https://github.blog/news-insights/product-news/introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, we were hacking the workflow definition to execute on a PR to test it. We don't want this running on every PR, because that would be wasteful and noisy. But we can easily make it run when the FFMpeg building script has changed, which is what we wanted before.
Previous versions of this PR had a trivial change to trigger CI. One of those runs: https://github.com/pytorch/torchcodec/actions/runs/11560100235?pr=313. The current one does not have that trivial change to the script, and the test does not run.