Skip to content

Better error message if metadata is missing in approximate mode #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 1 commit into from
Mar 6, 2025
Merged

Better error message if metadata is missing in approximate mode #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/torchcodec/decoders/_core/VideoDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,6 +1536,9 @@ int64_t VideoDecoder::secondsToIndexLowerBound(double seconds) {
case SeekMode::approximate: {
auto& streamMetadata =
containerMetadata_.allStreamMetadata[activeStreamIndex_];
TORCH_CHECK(
streamMetadata.averageFps.has_value(),
"Cannot use approximate mode since we couldn't find the average fps from the metadata.");
return std::floor(seconds * streamMetadata.averageFps.value());
}
default:
Expand All @@ -1560,6 +1563,9 @@ int64_t VideoDecoder::secondsToIndexUpperBound(double seconds) {
case SeekMode::approximate: {
auto& streamMetadata =
containerMetadata_.allStreamMetadata[activeStreamIndex_];
TORCH_CHECK(
streamMetadata.averageFps.has_value(),
"Cannot use approximate mode since we couldn't find the average fps from the metadata.");
return std::ceil(seconds * streamMetadata.averageFps.value());
}
default:
Expand All @@ -1575,6 +1581,9 @@ int64_t VideoDecoder::getPts(int64_t frameIndex) {
case SeekMode::approximate: {
auto& streamMetadata =
containerMetadata_.allStreamMetadata[activeStreamIndex_];
TORCH_CHECK(
streamMetadata.averageFps.has_value(),
"Cannot use approximate mode since we couldn't find the average fps from the metadata.");
return secondsToClosestPts(
frameIndex / streamMetadata.averageFps.value(), streamInfo.timeBase);
}
Expand All @@ -1591,8 +1600,12 @@ int64_t VideoDecoder::getNumFrames(const StreamMetadata& streamMetadata) {
switch (seekMode_) {
case SeekMode::exact:
return streamMetadata.numFramesFromScan.value();
case SeekMode::approximate:
case SeekMode::approximate: {
TORCH_CHECK(
streamMetadata.numFrames.has_value(),
"Cannot use approximate mode since we couldn't find the number of frames from the metadata.");
return streamMetadata.numFrames.value();
}
default:
throw std::runtime_error("Unknown SeekMode");
}
Expand All @@ -1613,8 +1626,12 @@ double VideoDecoder::getMaxSeconds(const StreamMetadata& streamMetadata) {
switch (seekMode_) {
case SeekMode::exact:
return streamMetadata.maxPtsSecondsFromScan.value();
case SeekMode::approximate:
case SeekMode::approximate: {
TORCH_CHECK(
streamMetadata.durationSeconds.has_value(),
"Cannot use approximate mode since we couldn't find the duration from the metadata.");
return streamMetadata.durationSeconds.value();
}
default:
throw std::runtime_error("Unknown SeekMode");
}
Expand Down
Loading