Skip to content

Add test to illustrate audio bug #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 1 commit into from
Mar 17, 2025
Merged

Add test to illustrate audio bug #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/decoders/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,23 @@ def test_pts(self, asset):
else:
assert pts_seconds == start_seconds

def test_decode_before_frame_start(self):
# Test illustrating bug described in
# https://github.com/pytorch/torchcodec/issues/567
asset = NASA_AUDIO_MP3

decoder = create_from_file(str(asset.path), seek_mode="approximate")
add_audio_stream(decoder)

frames, *_ = get_frames_by_pts_in_range_audio(
decoder, start_seconds=0, stop_seconds=0.05
)
all_frames, *_ = get_frames_by_pts_in_range_audio(
decoder, start_seconds=0, stop_seconds=None
)
# TODO fix this. `frames` should be empty.
torch.testing.assert_close(frames, all_frames)


if __name__ == "__main__":
pytest.main()
Loading