Skip to content

Remove torchvision test dependency #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 3 commits into from
Apr 23, 2025
Merged

Remove torchvision test dependency #648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a40672b
Remove torchvision test dependency
NicolasHug Apr 22, 2025
9a43049
Put back dep for CUDA job since we run the benchmarks
NicolasHug Apr 22, 2025
2dae6ab
empty
NicolasHug Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linux_cuda_wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
run: ${CONDA_RUN} python -m pip install --upgrade pip
- name: Install PyTorch
run: |
${CONDA_RUN} python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }}
${CONDA_RUN} python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }}
Copy link
Contributor

@scotts scotts Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still need torchvision here because of the GPU benchmarks.

Copy link
Contributor Author

@NicolasHug NicolasHug Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaaah I forgot we run those. We probably... shouldn't, since we never check 🤷

Copy link
Contributor

@scotts scotts Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some value in doing it, as it makes sure that the GPU benchmarks don't become stale. That is, it's not about the actual performance result from the benchmark, it's more a check that it's still usable. There may also be value in doing that on the CPU side as well.

${CONDA_RUN} python -c 'import torch; print(f"{torch.__version__}"); print(f"{torch.__file__}"); print(f"{torch.cuda.is_available()=}")'
- name: Install torchcodec from the wheel
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/linux_wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ jobs:

- name: Install test dependencies
run: |
python -m pip install --pre torchvision --index-url https://download.pytorch.org/whl/nightly/cpu
# Ideally we would find a way to get those dependencies from pyproject.toml
python -m pip install numpy pytest pillow

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/macos_wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ jobs:

- name: Install test dependencies
run: |
python -m pip install --pre torchvision --index-url https://download.pytorch.org/whl/nightly/cpu
python -m pip install numpy pytest pillow

- name: Delete the src/ folder just for fun
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reference_resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: |
# Note that we're installing stable - this is for running a script where we're a normal PyTorch
# user, not for building TorhCodec.
python -m pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu
python -m pip install torch --index-url https://download.pytorch.org/whl/cpu
python -m pip install numpy pillow

- name: Check out repo
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pip install -e ".[dev]" --no-build-isolation -vv

### Running unit tests

To run python tests run (please make sure `torchvision` is installed):
To run python tests run:

```bash
pytest test -vvv
Expand Down
Loading