Add pytest tmp_path #706
Merged
Add pytest tmp_path #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
approved these changes
Jun 2, 2025
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Good catch, thank you @Dan-Flores !
Dan-Flores
added a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tmp_path fixture to
test_bad_input_parametrized. By adding this argument, pytest will automatically create a temporary directory to store the decoder in whento_fileis tested.As a result, 'output.mp3' is not leftover after running the following test:
pytest test -vvv -k "test_bad_input_parametrized[to_file]"