Skip to content

Use main branch of test-infra for Windows builds #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasHug merged 2 commits into from
Aug 28, 2025
Merged

Use main branch of test-infra for Windows builds #854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88e1c72
Use main branch of test-infra for Windows builds
NicolasHug Aug 27, 2025
89c8d7b
fix?
NicolasHug Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/windows_wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,12 @@ jobs:
strategy:
fail-fast: false
name: Build and Upload Windows wheel
# TODO: use @main
uses: nicolashug/test-infra/.github/workflows/build_wheels_windows.yml@build-platform-windows
uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@main
with:
repository: pytorch/torchcodec
ref: ""
test-infra-repository: nicolashug/test-infra
Copy link
Contributor

@Dan-Flores Dan-Flores Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create a test-infra repository for this to work previously?

Copy link
Contributor Author

@NicolasHug NicolasHug Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sort of: that was just my custom branch on my own fork: https://github.com/NicolasHug/test-infra/tree/build-platform-windows/.github

I.e. that's just the branch that I created this PR from: pytorch/test-infra#6888

test-infra-ref: build-platform-windows
test-infra-repository: pytorch/test-infra
test-infra-ref: main
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
pre-script: packaging/pre_build_script.sh
# post-script: packaging/post_build_script.sh TODO: consider enabling post-build checks for Windows
Expand Down
Loading