Skip to content

Fix infinite recursion when _service is not set #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2025
Merged

Fix infinite recursion when _service is not set #100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573a2b0
Fix infinite recursion when _service is not set
casteryh Aug 30, 2025
5b392e5
Update src/forge/controller/service/interface.py
allenwang28 Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/forge/controller/service/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,16 @@ def _get_internal_state(self):

def __getattr__(self, name: str):
"""Forward all other attribute access to the underlying Service Actor."""
# No infinite recursion please
try:
_service = object.__getattribute__(self, "_service")
except AttributeError:
raise AttributeError(
f"'{self.__class__.__name__}' object has no attribute '{name}'"
)
# Forward everything else to the _service
if hasattr(self._service, name):
return getattr(self._service, name)

if hasattr(_service, name):
return getattr(_service, name)
raise AttributeError(
f"'{self.__class__.__name__}' object has no attribute '{name}'"
)
Loading