VLLM + torchstore integration test upgrade to match the new Policy APIs. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pradeepfn
changed the title
joecummings
reviewed
Sep 4, 2025
src/forge/actors/policy.py
Outdated
| return self.weights_version | ||
|
|
||
| @endpoint | ||
| async def get_model_params(self) -> Dict[str, torch.Tensor]: |
There was a problem hiding this comment.
If it's only for testing purposes, can you underscore it please?
joecummings
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy engine introduce a Policy service. This broke the existing vllm + torchstore example script.
This diff fixes it.
2 Will fix the multi-worker case in followup PR.