update installation script for conda/ubuntu users without sudo access #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
allenwang28
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
awesome, thanks @AlirezaShamsoshoara for the fixes! Could you remove the *_only and check this in?
scripts/install.sh
Outdated
| # Check sudo access | ||
| check_sudo() { | ||
| # Check sudo access only | ||
| check_sudo_only() { |
There was a problem hiding this comment.
could you remove this and install_systems_packages_sudo_only?
There was a problem hiding this comment.
Thanks @allenwang28 for quickly review that. Just removed those two _only functions from the script.
|
looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes mainly addresses the installation issue for users without SUDO access (Conda users) or Ubuntu users.
Changes: