spawn service based trainer #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pbontrager
reviewed
Sep 8, 2025
apps/rl/main.py
Outdated
| await asyncio.gather( | ||
| buffer.setup.call(), | ||
| trainer.setup.call(), | ||
| trainer = await spawn_service( |
There was a problem hiding this comment.
These should still be in a asyncio.gather
apps/rl/main.py
Outdated
| buffer.setup.call(), | ||
| trainer.setup.call(), | ||
| trainer = await spawn_service( | ||
| ServiceConfig(procs_per_replica=1, with_gpus=True, num_replicas=4), |
There was a problem hiding this comment.
This still could have been sourced from the config with ServiceConfig(**cfg.trainer.pop("service")) but we don't have to change that for this PR
There was a problem hiding this comment.
Will add as part of next integration test PR. Did not occur to me that the yaml obj get parsed into a regular python dict. thanks.
|
PTAL. thanks! |
pbontrager
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1\ The existing code uses spawn_actor API. this is being deprecated. This diff ports the example to new service API.
2\ With new service API, procs/host details are part of the Service config. Hence I removed from the yaml config.
3\ With new service API, we don't have to call the setup called explicity, it is being called by the launch_service routines.
Run output:
(forge) [[email protected] ~/forge_fork (ts_trainer)]$ python -m apps.rl.main --config apps/rl/llama3_8b.yaml
[0] model.safetensors.index.json not found at hf_assets_path: ./tests/assets/tokenizer/model.safetensors.index.json. Defaulting to saving a single safetensors file if checkpoint is saved in HF format
[0] model.safetensors.index.json not found at hf_assets_path: ./tests/assets/tokenizer/model.safetensors.index.json. Defaulting to saving a single safetensors file if checkpoint is saved in HF format
[0] model.safetensors.index.json not found at hf_assets_path: ./tests/assets/tokenizer/model.safetensors.index.json. Defaulting to saving a single safetensors file if checkpoint is saved in HF format
[0] model.safetensors.index.json not found at hf_assets_path: ./tests/assets/tokenizer/model.safetensors.index.json. Defaulting to saving a single safetensors file if checkpoint is saved in HF format
Services initialized....
shutting down...