-
Notifications
You must be signed in to change notification settings - Fork 19
Add YAML config file for grpo.main #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ervice issue in vllm main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many comments, but mostly minor
apps/grpo/main.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I copied from other main files. But looks like it can run without sys.exit(xx)
. Removed.
src/forge/data/utils.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun - we may want to put all of this in its own "frontend" file called omegaconf_frontend (idk, smth like that) so people can keep track of things they might want to switch out with their own frontend.
Thanks for splitting up the PRs |
ReplayBuffer
andDatasetActor
services
being passed as part of config.Test
python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml
python -m apps.vllm.main --config apps/vllm/llama3_8b.yaml