-
Notifications
You must be signed in to change notification settings - Fork 24
Trainer/Policy Engine Re-sharding weight sync. #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm encountering following error, even when running the already established single worker UT. 2025-09-16T15:51:09.716656Z ERROR error invoking get_reconstruction api, error: ReqwestMiddlewareError(Middleware(Request failed after 5 retries Caused by: 2025-09-16T15:51:18.623345Z WARN Reqwest(reqwest::Error { kind: Request, url: "https://cas-server.xethub.hf.co/reconstruction/e2a9405ede2b482e4d566aadf8bf470bd4e42542ef327709edadf724e1950d47", source: hyper_util::client::legacy::Error(Connect, ConnectFailed(ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Name or service not known" }))) }). Retrying... 2025-09-16T15:51:18.623379Z ERROR error invoking get_reconstruction api, error: ReqwestMiddlewareError(Middleware(Request failed after 5 retries Caused by: ------------------------------------------------------------------------------------- Captured stderr setup ------------------------------------------------------------------------------------- |
Can you try |
Getting following error.
|
@joecummings confirmed that there is a known issue in the DP sharding. Thanks Joe!. Going to try out TP. |
Apparently, meta-pytorch/torchstore#32 solves the issue. Let me test. |
pull/32 fixed the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIX THE LINT :)
In this PR;
Summary:
Test:
pytest tests/integration_tests/test_policy_update.py::TestWeightSync::test_policy_update_tp