[1/N] Core abstractions #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vidhyav
commented
Sep 19, 2025
src/forge/data_models/prompt.py
Outdated
|
|
||
| # Multi-turn messages, each turn is a message. | ||
| messages: Sequence[Message] | ||
| metadata: Any | None = None |
There was a problem hiding this comment.
@Ritesh1905 should I remove the metadata?
|
Looks good. Just remove the metadata in the prompt |
Ritesh1905
approved these changes
Sep 19, 2025
Summary: Comprises of: (a) Prompts (b) Completions (c) Episodes Test Plan: None. Reviewers: Ritesh1905 Subscribers: Tasks: Tags:
Ritesh1905
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Comprises of: (a) Prompts (b) Completions (c) Episodes Test Plan: None. Reviewers: Ritesh1905 Subscribers: Tasks: Tags: Co-authored-by: Vidhya Venkat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The first set of core abstractions based off of feedback from #178
Comprises of:
(a) Prompts
(b) Completions
(c) Episodes
Test Plan: None. We will be using this to run correctness tests.
Reviewers: Ritesh1905
Subscribers:
Tasks:
Tags: