Skip to content

Conversation

JenniferWang
Copy link
Contributor

@JenniferWang JenniferWang commented Sep 22, 2025

_values is deleted from the ValueMesh in meta-pytorch/monarch@1f43007

Tested on the toy_rl app with use_dcp: bool = False

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 22, 2025
@JenniferWang JenniferWang reopened this Sep 22, 2025
@JenniferWang JenniferWang marked this pull request as draft September 22, 2025 20:21
Copy link
Contributor

@allenwang28 allenwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if everything works!

@JenniferWang JenniferWang marked this pull request as ready for review September 23, 2025 01:48
@JenniferWang JenniferWang marked this pull request as draft September 23, 2025 02:05
@JenniferWang JenniferWang marked this pull request as ready for review September 23, 2025 02:55
@JenniferWang JenniferWang merged commit 1d6c787 into meta-pytorch:main Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants