Skip to content

Conversation

DNXie
Copy link
Member

@DNXie DNXie commented Sep 23, 2025

Context: #160

  • Rename ServiceEndpoint.choose() to route() and call() to fanout().
  • Updated all the use cases accordingly.

Test
All unit tests and

python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 23, 2025
@DNXie DNXie force-pushed the rename_choose_call branch from fb49a49 to 236a27f Compare September 24, 2025 18:13
@DNXie DNXie requested a review from allenwang28 September 24, 2025 18:18
@DNXie DNXie marked this pull request as ready for review September 24, 2025 18:18
class ServiceEndpoint(Generic[P, R]):
"""An endpoint object specific to services.
This loosely mimics the Endpoint APIs exposed in Monarch, with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring would be like,

This extends Monarch's actor APIs:

  • route(): Routes the request to a replica
  • fanout(): Runs the request on all replicas

Note that Monarch's native actor APIs will not apply for services.

Copy link
Contributor

@allenwang28 allenwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty Danning, please inform the team!

@DNXie DNXie merged commit 454558f into meta-pytorch:main Sep 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants